Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueberry theme design view problem #2

Open
Simushy opened this issue Oct 16, 2023 · 20 comments
Open

Blueberry theme design view problem #2

Simushy opened this issue Oct 16, 2023 · 20 comments

Comments

@Simushy
Copy link

Simushy commented Oct 16, 2023

Some file overwrites config from .scss files and background color on design view of database is still white making it unreadable unless you get really close to your monitor.
issue

@maisondasilva
Copy link

Is it possible to send corrections @movahhedi ?

In addition to this, I found these

image

For fix

`.alert-info

--bs-alert-bg:

background-color: #2c2c3d`

and

image

For fix

`.form-check-input:checked

background-color: #055160`

The only one I couldn't figure out how to solve was this!
In import file

image

Thanks

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

found fix, can guide you on how to fix it, do u have dc?

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

or actually when i get home I'll just paste fix here

@movahhedi
Copy link
Owner

Pull requests are always welcome.
Thank you.

@maisondasilva
Copy link

@movahhedi The problem is that I've never made themes for phpmyadmin and I have no idea which file to modify!
That's why I only posted the correction, because I did it using developer mode in the browser!

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

i can do it, gimme a sec

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

@maisondasilva what phpmyadmin version ur using?

@maisondasilva
Copy link

@maisondasilva what phpmyadmin version ur using?

5.2.1

@maisondasilva
Copy link

@andriawan I saw that you sent another correction, do you think you can help with this correction too, I don't know much about theme phpmyadmin

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

created pull request, fixed import tab and designer

@movahhedi
Copy link
Owner

Where did you create the pull request? If you do it in this fork, I can run the GitHub Actions as a not-first-time contributor ti speed up the process.

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

fork,
got repo and uploaded file from my pc with fix

@maisondasilva
Copy link

maisondasilva commented Nov 9, 2023

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

so my vscode formatted the code to readable state xD if u want i can obfuscate it again

@maisondasilva
Copy link

maisondasilva commented Nov 9, 2023

@Simushy I noticed that the 270KB file became 323KB, were there many changes? Can you send it as the original I think this helps to compress the size!

image

@maisondasilva
Copy link

What extension do you use in your vscode to minify @Simushy

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

fixed format, pull request should be updated automatically i believe
extension that formatted it in the first place was prettier
now i just copied original and just pasted the changes, it should be good now

@maisondasilva
Copy link

@movahhedi phpmyadmin#109

@Simushy
Copy link
Author

Simushy commented Nov 9, 2023

forgot about the designer view in the end, updated again, sorry

@andriawan
Copy link

@maisondasilva mostly i just modified .scss file. I'll check the issue later in my free time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants