Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-checking caching keys for DiskLru cache #19

Closed
motorro opened this issue Feb 12, 2020 · 1 comment
Closed

Double-checking caching keys for DiskLru cache #19

motorro opened this issue Feb 12, 2020 · 1 comment
Assignees
@motorro
Labels
enhancement New feature or request

Comments

@motorro
Copy link
Owner

motorro commented Feb 12, 2020 •
edited
Loading

DiskLru cache uses 120-symbol (64 in a released 2.0.2) a-zA-Z0-9-_ cache keys which may not be enough for some scenarios. One may hash original parameters but clashing takes place in that case. Need some double-check of caching parameters when reading to avoid returning wrong data
@motorro motorro added the enhancement New feature or request label Feb 12, 2020
@motorro motorro self-assigned this Feb 12, 2020
@motorro
Copy link
Owner Author

motorro commented Feb 12, 2020 •
edited
Loading

OkHttp with 120 symbol cache:

fun key(url: HttpUrl): String = url.toString().encodeUtf8().md5().hex()

motorro added a commit that referenced this issue Feb 12, 2020
@motorro
Cache-friend delegate with params check
6f14795 
References: #19
motorro added a commit that referenced this issue Feb 13, 2020
@motorro
Minor. Rx error hook.
9896895 
References: #19
motorro added a commit that referenced this issue Feb 13, 2020
@motorro
Caching delegates with keys for Serializable.
d73b637 
References: #19
motorro added a commit that referenced this issue Feb 13, 2020
@motorro
Caching delegates with keys for kotlin serialization.
899862d 
References: #19
motorro added a commit that referenced this issue Feb 13, 2020
@motorro
Lowercase letters for md5 cache keys.
bcdd8ab 
References: #19
motorro added a commit that referenced this issue Feb 13, 2020
@motorro
Re-packaging and removing default key-gen params.
518dd1f 
References: #19
motorro added a commit that referenced this issue Feb 13, 2020
@motorro
Cache key hashing documented.
66947bb 
References: #19
@motorro motorro mentioned this issue Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@motorro motorro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@motorro