Migrate build to rollup #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprecioso
commented
Jun 16, 2019
| }, | ||
| "dependencies": { | ||
| "symbol-observable": "^1.2.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@most/core": "^1.3.2" | ||
| "@most/core": "^1.3.2", | ||
| "@most/scheduler": "^1.2.2" |
There was a problem hiding this comment.
The package requires @most/scheduler directly. Therefore, it is good ettiquette to declare that in the package.json.
This will also become important as yarn 2 and pnpm won't let this module access any dependencies it has not declared.
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current devDependencies of most-observable is impossible to install because
event-streamis pinned at version3.3.6, which had to be taken off the registry as it included malicious code.Moreover
lectrois using webpack internally, which outputs more code thanrollup. It also only outputs commonjs code, which negates the tree-shaking advantages of@most/core.@most/corealready uses rollup for their build process. It also allows to create both a commonjs build and a es modules build. Therefore I'd like to suggest it for the build process of this package.