Critical code review PR - Last sprint handover checklist of 0.10.0 release #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwa-vyom
commented
Dec 13, 2024
...tify-plugin/src/main/java/io.mosip.certify.mock.integration/service/DataProviderService.java
Outdated
Show resolved
Hide resolved
...tify-plugin/src/main/java/io.mosip.certify.mock.integration/service/DataProviderService.java
Outdated
Show resolved
Hide resolved
...lugin/src/main/java/io.mosip.certify.mock.integration/service/MockCSVDataProviderPlugin.java
Outdated
Show resolved
Hide resolved
mock-certify-plugin/src/main/java/io/mosip/certify/util/CSVReader.java
Outdated
Show resolved
Hide resolved
mock-certify-plugin/src/main/java/io/mosip/certify/util/CSVReader.java
Outdated
Show resolved
Hide resolved
mock-certify-plugin/src/main/java/io/mosip/certify/util/CSVReader.java
Outdated
Show resolved
Hide resolved
...ify-plugin/src/main/java/io.mosip.certify.mock.integration/service/MockVCIssuancePlugin.java
Outdated
Show resolved
Hide resolved
mock-certify-plugin/src/main/java/io/mosip/certify/mock/integration/mocks/MdocGenerator.kt
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (csvRegistryURI.startsWith("http")) { | ||
| // download the file to a path: usecase(docker, spring cloud config) | ||
| filePath = restTemplate.execute(csvRegistryURI, HttpMethod.GET, null, resp -> { | ||
| File ret = File.createTempFile("download", "tmp"); |
Check warning
Code scanning / CodeQL
Local information disclosure in a temporary directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created just to add the review comments as part of the critical code review task of last sprint handover checklist for release of 0.10.0 version.
** THIS PR SHOULD NOT BE MERGED **