Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pytorch to 2.6.0 #3763

Merged
merged 13 commits into from
Feb 22, 2025
Merged

Bump pytorch to 2.6.0 #3763

merged 13 commits into from
Feb 22, 2025

Conversation

rithwik-db
Copy link
Contributor

@rithwik-db rithwik-db commented Feb 8, 2025 •
edited
Loading

What does this PR do?

Upgrading to Torch 2.6

Run of daily tests: https://github.com/mosaicml/composer/actions/runs/13463042795

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@rithwik-db rithwik-db requested a review from a team as a code owner February 8, 2025 01:06
@rithwik-db rithwik-db changed the title working on updating to torch 2.6 Bump pytorch to 2.6 Feb 8, 2025
@rithwik-db rithwik-db changed the title Bump pytorch to 2.6 Bump pytorch to 2.6.0 Feb 8, 2025
@rithwik-db rithwik-db changed the title Bump pytorch to 2.6.0 [WIP] Bump pytorch to 2.6.0 Feb 8, 2025
@antoinebrl antoinebrl mentioned this pull request Feb 10, 2025
Open
@rithwik-db rithwik-db requested a review from a team as a code owner February 19, 2025 21:51
@rithwik-db rithwik-db force-pushed the update-torch-2.6 branch 2 times, most recently from 829ef6d to 7e58301 Compare February 19, 2025 22:49
@rithwik-db
type annotations
05dc899 
reformatted
@rithwik-db rithwik-db changed the title [WIP] Bump pytorch to 2.6.0 Bump pytorch to 2.6.0 Feb 20, 2025
bigning
bigning reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@bigning bigning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please manually trigger a daily test on this branch https://github.com/mosaicml/composer/actions/workflows/daily.yaml . The currently daily test is broken (cc oncall @milocress ), but you can temporarily remove that failed tests.

@rithwik-db rithwik-db requested a review from dakinggg February 20, 2025 20:22
dakinggg
dakinggg reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but won't approve until the pull request target is reverted back

@rithwik-db rithwik-db requested a review from dakinggg February 21, 2025 21:51
@rithwik-db rithwik-db enabled auto-merge (squash) February 22, 2025 00:08
@dakinggg dakinggg disabled auto-merge February 22, 2025 00:26
@dakinggg dakinggg merged commit 3608793 into main Feb 22, 2025
26 checks passed
@dakinggg dakinggg deleted the update-torch-2.6 branch February 22, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigning bigning bigning left review comments

@dakinggg dakinggg dakinggg approved these changes

@milocress milocress Awaiting requested review from milocress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rithwik-db @bigning @dakinggg