Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix row splitting #84

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix row splitting #84

merged 3 commits into from
Dec 19, 2024

Conversation

rdmorin
Copy link
Contributor

@rdmorin rdmorin commented Dec 18, 2024

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

Checklist for all PRs

Required

  • I ensured not to prepend the functions existing in both GAMBLR.data and GAMBLR.results with <package>::function() syntax.
  • I ensured not to add GAMBLR.data or GAMBLR.results to the @import section of the documentation

@Kdreval Kdreval added the bug Something isn't working label Dec 18, 2024
@Kdreval Kdreval linked an issue Dec 18, 2024 that may be closed by this pull request
@lkhilton
Copy link
Contributor

Please see this PR for accompanying changes. I ensured that the colours in the oncoplot match the right barplot, and retained factor levels of the input splitGeneColumn argument.

Copy link
Contributor

@Kdreval Kdreval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

@Kdreval Kdreval merged commit 11ebd68 into master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lost splitGeneGroups functionality in prettyoncoplot
3 participants