prettyoncoplot updates #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lton-prettyoncoplot
lkhilton
reviewed
Dec 4, 2024
R/prettyOncoplot.R
Outdated
| prettyOncoplot = function( | ||
| maf_df, | ||
| cnv_df, | ||
| onco_matrix_path, |
There was a problem hiding this comment.
This is now the only reference to onco_matrix_path in the whole function. Is it time to remove it and the recycleOncomatrix arg?
There was a problem hiding this comment.
just pushed the update deprecating this argument! ✅
lkhilton
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #81 and also updates prettyOncoplot to properly handle the noncoding variants.
The code has also been restructured to ensure consistent formatting and indentation. More in-line documentation added to improve readability
Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
<package>::function()syntax.@importsection of the documentation