Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked oncoplots #73

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Stacked oncoplots #73

merged 7 commits into from
Oct 2, 2024

Conversation

rdmorin
Copy link
Contributor

@rdmorin rdmorin commented Sep 25, 2024

Pull Request Checklists

This is a massive extension to the prettyOncoplot functionality. Fairly thoroughly tested but more testing would be appreciated!

Checklist for all PRs

Required

  • I ensured not to prepend the functions existing in both GAMBLR.data and GAMBLR.results with <package>::function() syntax.
  • I ensured not to add GAMBLR.data or GAMBLR.results to the @import section of the documentation

@Kdreval
Copy link
Contributor

Kdreval commented Oct 1, 2024

Thanks!
I think all looks good - just missing a few documentation updates. I think this is the most relevant part from the check:

❯ checking Rd \usage sections ... WARNING
  Documented arguments not in \usage in documentation object 'map_metadata_to_colours':
    ‘as_vector’
  
  Undocumented arguments in documentation object 'prettyOncoplot'
    ‘numeric_heatmap_type’ ‘numeric_heatmap_location’
  

Let me know if I should fix those 😄

@rdmorin rdmorin requested a review from Kdreval October 2, 2024 20:11
@Kdreval Kdreval merged commit bd375a9 into master Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants