Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing README and prettyOncoplot issues #59

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Conversation

Kdreval
Copy link
Contributor

@Kdreval Kdreval commented Mar 22, 2024

This PR is to address the following issues:

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

Checklist for all PRs

Required

  • I ensured not to prepend the functions existing in both GAMBLR.data and GAMBLR.results with <package>::function() syntax.
  • I ensured not to add GAMBLR.data or GAMBLR.results to the @import section of the documentation

@Kdreval Kdreval added bug Something isn't working enhancement New feature or request labels Mar 22, 2024
@Kdreval Kdreval self-assigned this Mar 22, 2024
This was linked to issues Mar 22, 2024
@Kdreval
Copy link
Contributor Author

Kdreval commented Mar 22, 2024

This page of the website is already generated with this branch and shows that both issues in the prettyOncoplot are properly addressed: https://morinlab.github.io/GAMBLR.viz/tutorials/oncoplot.html#annotating-significance-of-mutation-frequencies-in-sample-groups

@Kdreval Kdreval merged commit 631eba4 into master Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prettyOncoplot bugs README needs update
2 participants