Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated option in benchmarks script #3138

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

manuelmauro
Copy link
Contributor

What does it do?

When running run-benches-for-runtime.sh to generate the runtime weights, the following warning appears in the logs:

Using the chain spec instead of the runtime to generate the genesis state is deprecated. Please remove the `--chain`/`--dev`/`--local` argument, point `--runtime` to your runtime blob and set `--genesis-builder=runtime`. This warning may become a hard error any time after December 2024. 

This PR updates the script to use --runtime <runtime> instead of --chain=<chain-spec>.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Copy link
Contributor

github-actions bot commented Jan 17, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2284 KB (no changes) ✅

Moonbeam runtime: 2276 KB (no changes) ✅

Moonriver runtime: 2276 KB (no changes) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2284 KB (+252 KB compared to latest release) ⚠️

Moonbeam runtime: 2276 KB (+264 KB compared to latest release) ⚠️

Moonriver runtime: 2276 KB (+264 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Coverage Report

@@                                Coverage Diff                                @@
##           master   manuel/update-deprecation-in-benchmarks-script     +/-   ##
=================================================================================
  Coverage   74.58%                                           74.58%   0.00%     
  Files         377                                              377             
+ Lines       96042                                            96048      +6     
=================================================================================
+ Hits        71632                                            71633      +1     
+ Misses      24410                                            24415      +5     
Files Changed Coverage
/runtime/common/src/apis.rs 28.56% (-0.29%) 🔽
/runtime/moonbase/src/lib.rs 50.60% (+0.26%) 🔼
/runtime/moonbeam/src/lib.rs 44.65% (+0.22%) 🔼
/runtime/moonriver/src/lib.rs 44.87% (+0.22%) 🔼

Coverage generated Tue Jan 21 16:22:03 UTC 2025

@manuelmauro manuelmauro changed the title Update deprecation in benchmarks script Update deprecated option in benchmarks script Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant