Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore-npm-dependencies setting #277

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

PhMemmel
Copy link
Contributor

@PhMemmel PhMemmel commented Mar 7, 2024

Closes #276

@stronk7
Copy link
Member

stronk7 commented Mar 7, 2024

Thanks @PhMemmel ,

going to amend your commit from here to make CIs happy and then will merge this.

Normally I'd ask you for the changes, but as far as we are going to make a release later today, better I get on this now. Will add one extra commit to your branch.

Ciao :-)

@PhMemmel
Copy link
Contributor Author

PhMemmel commented Mar 7, 2024

Appreciate this very much, feel free to make any changes. Thank you!

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (158d5fd) to head (c2ce78d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #277      +/-   ##
============================================
+ Coverage     87.92%   88.04%   +0.12%     
- Complexity      728      731       +3     
============================================
  Files            75       75              
  Lines          2228     2234       +6     
============================================
+ Hits           1959     1967       +8     
+ Misses          269      267       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7
Copy link
Member

stronk7 commented Mar 7, 2024

Ok, I've added one extra commit on top of your branch.

Basically it renames the new option to no-plugin-node (to better differentiate moodle node dependencies and plugin node dependencies), fixes tests and covers the new logic a little bit better.

Let's see if GHA is happy...

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can now be considered ok enough, thanks!

@stronk7 stronk7 merged commit f4d43c3 into moodlehq:main Mar 7, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to avoid installing npm dependencies for a plugin
2 participants