-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a warning annotation when "master" branch usage is detected #270
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
============================================
+ Coverage 84.77% 85.10% +0.33%
- Complexity 720 722 +2
============================================
Files 75 75
Lines 2226 2216 -10
============================================
- Hits 1887 1886 -1
+ Misses 339 330 -9 ☔ View full report in Codecov by Sentry. |
6dd9178
to
25276e2
Compare
Side note, I'm not sure what's going with Travis since 1-2 weeks ago, maybe they are upgrading their environments because all our PostgreSQL related tests are failing with different errors (not package available, not running @ port xxxx, ...). I'll take a look to that, but apart from this issue, just sharing why it's failing. Ciao :-) |
Other than that, I think this is ready for review as far as it seems to be working ok. Feel free to suggest a better wording or whatever (I'm not good there!). Ciao :-) |
Ok, confirmed, Travis has changed PostgreSQL default port from the exceptional 5432 that it had since last year to the usual 5433 that they have for all versions since v10. This run (that uses the 2nd commit added here) is now running ok: https://app.travis-ci.com/github/moodlehq/moodle-plugin-ci/builds/268805831 So, if we get everything green, we can go with this. 2 issues fixed in 1 PR. Ciao :-) |
ec2171c
to
9d261ff
Compare
9d261ff
to
9d29aa1
Compare
Grrr, it's flip.flopping (the PostgreSQL 13 port). Last run failed with the change back to 5433. And now it's showing 5432 again:
(yesterday it was showing 5433, that's the reason I added the 2nd commit) I'm going to switch back to 5432, removing the second commit in this PR and doing a few more tests... grrr. Ciao :-) |
9d29aa1
to
25276e2
Compare
That way, both the web UI and the email from GitHub will show the recommendation about to move to the new "main" branch. Also, unrelated, exclude some unreachable code from code coverage analysis.
25276e2
to
28605ed
Compare
Ok, back to port 5432 (the original one). Seems to be working now. What a waste of time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks Mr. @kabalin ! |
That way, both the web UI and the email from GitHub will show the recommendation about to move to the new "main" branch.
Also, unrelated, exclude some unreachable code from code coverage analysis.
Here there is an example to show how the annotation looks like (at the bottom):
https://github.com/stronk7/moodle-plugin-ci/actions/runs/7812729398
Note that an unrelated 2nd commit has been added about to try to keep Travis working, because it has started to fail recently (maybe they changed the PostgreSQL ports again, grrr).