Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#188 Fix scripts in MacOS #282

Merged
merged 1 commit into from
Mar 12, 2024
Merged

#188 Fix scripts in MacOS #282

merged 1 commit into from
Mar 12, 2024

Conversation

NoelDeMartin
Copy link
Contributor

@NoelDeMartin NoelDeMartin commented Mar 12, 2024

Fixes #188.

grep -P is not supported in MacOS, replacing it with sed should work everywhere.

`grep -P` is not supported in MacOS, replacing it with `sed` should work everywhere.
@stronk7
Copy link
Member

stronk7 commented Mar 12, 2024

Personal opinion: I think that anybody trying to use any of our tools should have their GNU incarnations, because it's not only grep the one with differences between GNU and BSD.

For Macs, there are a bunch of package managers (homebrew, macports, ...) that have them, and it's easy to make them to get priority over the OS ones.

Anyway, I don't oppose to this change. Just hope GNU sed is the same 100% than BSD sed (I don't mind because I've the GNU one installed here, but be warned that they may be different too!

Edited: Just searched by curiosity, and there are also differences with sed (link). So I insist about always trying to get the GNU alternatives, there is not guarantee out from them.

@stronk7 stronk7 merged commit dabb6a6 into moodlehq:main Mar 12, 2024
113 checks passed
@stronk7
Copy link
Member

stronk7 commented Mar 12, 2024

Merged, thanks!

@NoelDeMartin
Copy link
Contributor Author

Thanks for merging @stronk7. We have tested these in MacOS and they work without installing any special packages, so hopefully that makes it work everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mac] Unsupported grep flags used in MOODLE_DOCKER_APP_RUNTIME inference
2 participants