New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Meteor 3 #93

Open

leonardoventurini wants to merge 374 commits into master from feature/fiberless

Contributor

leonardoventurini commented Feb 3, 2023 •

edited

Loading

Remove fibers from the agent and integrate with Async Hooks and Async Local Storage.

Contributor Author

leonardoventurini commented Apr 27, 2023

Milestone

Tests pass on Meteor's future release 3.0 branch

Contributor Author

leonardoventurini commented Jun 1, 2023

Right now there is no way to know if a promise has been awaited or resolved in the background. What we can do is assume that an event which does not have other events in parallel has been awaited.

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/tracer/tracer.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/ntp.js Outdated Show resolved Hide resolved

zodern reviewed

View reviewed changes

lib/models/system.js

@@ @@ -81,12 +80,6 @@ SystemModel.prototype.buildPayload = function () { @@
                 metrics.mongoPoolCheckedOutConnections = driverMetrics.checkedOut;
                 metrics.mongoPoolCreatedConnections = driverMetrics.created;
-                const fiberMetrics = getFiberMetrics();

Member

zodern Jun 5, 2023 •

edited

Loading

Would there be any async hooks/ALS metrics that would be useful instead? Can we track how many hooks or ASL stores are being used in the app?

Contributor Author

leonardoventurini Jun 9, 2023

I think we can, will research.

lib/common/utils.js Outdated Show resolved Hide resolved

lib/common/utils.js Show resolved Hide resolved

lib/als/async-hook.js Outdated Show resolved Hide resolved

lib/als/async-hook.js Outdated Show resolved Hide resolved

lib/als/async-hook.js Outdated Show resolved Hide resolved

lib/als/async-hook.js Outdated Show resolved Hide resolved

lib/als/async-hook.js Outdated Show resolved Hide resolved

lib/als/async-hook.js Outdated Show resolved Hide resolved

leonardoventurini commented

View reviewed changes

lib/get-package-versions.js Outdated Show resolved Hide resolved

leonardoventurini added 16 commits

June 27, 2023 10:12


          add base metrics

b6103a0


          add interval tree


          fix testing issues and improve async event filtering

cfef5ce


          fix tests and revert sibling logic

2ea716a


          add info to async readme

f112ca9


          remove direct event creation for async resources

aa255b1


          fix tests; remove tests for async events

b706798


          simplify interval union

e61182c


          fix metrics and remove unused code

ab0234d


          hardcode agent version

23d8f61


          fix deprecation warning

6edc058


          upgrade package

6dabd0d


          adjust versions

7b6dfef


          make it adaptive instead

b8a3d2b


          run tests on alpha 10

1ab906e


          test adjustments

733c0bd

zodern and others added 29 commits

December 20, 2024 18:29


          Fix importing @monti-apm/core

8942e32


          Fix traceJob for Meteor 3

d3f93ef


          Update npm-shrinkwrap

cb2b60f


          Instrument quave:synced-cron

fefaeef


          Track async time in jobs

a48a81b


          Fix NaN in job metrics

0ca5038


          Remove node 4 websocket check


          Adjust flaky test

a96c278


          Speed up tracer tests

fba4342


          Update @monti-apm/core

047de80


          v3.0.0-beta.11

98c138e


          Optimize await detector

c973934


          Update @monti-apm/core

2000c2e


          Fix wrapping Promise constructor

21b3858


          Add verification of current info

ad7cfc2


          v3.0.0-beta.12

003e9df


          Merge branch 'master' into feature/fiberless

d01b575


          Fix lint errors

c2bb93a


          Add _disableAwaitDetector method

110242b


          v3.0.0-beta.13

fc093c5


          3.0: Fix redis subscriber process not being awaited

a7ca6dd


          Merge pull request #138 from alisnic/fix/optimistic-flicker

f920f85

3.0: Fix redis subscriber process not being awaited


          Update @monti-apm/core

97ab4f9


          Update npm-shrinkwrap

925bcb1


          Remove http dependency

b02623a


          Add debug logs for connecting

f5d5ddc


          v3.0.0-beta.14

872c8fc


          Update npm-shrinkwrap.json

d57e301


          Update versions for tests

a786a57

alisnic commented Jan 28, 2025 •

edited

Loading

@zodern beta14 fixed TLA issue I reported in #134, but not completely. Right now it appears only in unit tests:

$ meteor test --driver-package meteortesting:mocha --settings config/unit-test.json --port 5005 --raw-logs --exclude-archs 'web.browser.legacy, web.browser'

[[[[[ Tests ]]]]]                             

=> Started proxy.                             
=> Started MongoDB.                           

=> Linted your app. No linting errors.        
RedisOplog - Established connection to redis. 

packages/core-runtime.js:189
            throw error;
            ^

TypeError: TwitterMediaUpload is not a constructor
    at Suite.<anonymous> (<snip>/mediaUpload.tests.ts:29:18)
    at Object.create (/Users/alisnic/.meteor/packages/meteortesting_mocha-core/.8.2.0.1s90yp2.o02v++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/mocha/lib/interfaces/common.js:148:19)

Mocha versions:

meteortesting:mocha@3.2.0
meteortesting:mocha-core@8.2.0

If I start the server, the error does not appear. If I remove montiapm:agent from .meteor/packages, the error does not appear as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet