Add support for registering new protocol #9

tejaede · 2021-09-21T15:46:07Z

Applications using montage-geo may need to support non-standard protocols. Fetching data for these protocols can be implemented by specializing feature-delegate and map-image-delegate. What's missing is a way for the map to identify whether a layer with a non-standard protocol is a feature layer or a tile layer.

For reference, the map categorizes layers using the following bindings:

            this.defineBinding("_tileLayers", {
                "<-":   "layers.filter{protocol.defined() && " +
                        "protocol.supportsTileImageRequests && " +
                        "(!protocol.supportsFeatureRequests || featureMinZoom > ^zoom)} ?? " +
                        "[]"
            });
            this.defineBinding("_featureLayers", {
                "<-":   "layers.filter{protocol.defined() && " +
                        "(!protocol.supportsTileImageRequests || " +
                        "(protocol.supportsFeatureRequests && featureMinZoom <= ^zoom))} ?? " +
                        "[]"
            });

https://github.com/montagejs/montage-geo/blob/features/contour/ui/map.reel/map.js#L26-L36

This commit adds a new class method to Protocol to create and register a new protocol with the necessary flags.

Allows the map to be stretched to fit a target DOM element

The static map will now automatically determine the appropriate zoom detail level based on the client devicePixelRatio. Consequently, the static map now accepts bounds instead of a center and zoom level.

Montage Geo extends the GeoJson specification by adding an additional style property to feature. If a feature has a style property it is serialized into the GeoJson object and deserialized when read in.

The static map now draws features if the layer being drawn has a feature collection property.

Remove reference to unused anchor

Icons are now positioned from their top left corner (like the HTML 5 canvas API) instead of its center.

The actual image of a MapImage may be smaller than the MapImage's size, e.g. when the image service returns a smaller image than what was specified due to exceeding max export size limits.

Layers are fetched through montage-data service by making a fetch for Layer with a criteria that includes the Protocol and source URL. Intern- ally the layer service delegates the fetch to a child service special- ized for that protocol.

- Set Protocol.ArcGIS.supportsFeatureRequests to true - Fix the featureMinZoom flags in the map bindings determining what is a feature layer and what is a tile layer. featureMinZoom is the minimum zoom at which a layer can show features. This means a layer shall be a feature layer is the current map zoom is greater than or equal to the layer's featureMinZoom.

- Call super in constructor - Update images on map move

Create a collection in FeatureCollectionOverlay if a layer is assigned and store the fetched features in that collection.

Logging for each symbol negatively affects performance when removing a layer with many features.

FeatureCollectionOverlay assumed that it had a map when it received a collection. This commit allows the developer to assign the collection to the overlay before it is added to the map.

johnnykahalawai and others added 30 commits August 13, 2021 13:42

...

0a6ada4

Add static map with arcgis imagery

05eff4c

Implement feature drawing on static map

0af70ea

Invalidate mercator view bounds cache

a16d938

Support cross-antimeridian bounds with arcgis

4f863ed

Remove explicit size styling on map

d593bf4

Allows the map to be stretched to fit a target DOM element

Support drawing across the anti-meridian

f794926

Support feature style icons

a7dbcca

Add featureRenderScale property

2b07772

Fix montage-testing dependency

326f6cf

Add support for DPI scaling

ffce289

The static map will now automatically determine the appropriate zoom detail level based on the client devicePixelRatio. Consequently, the static map now accepts bounds instead of a center and zoom level.

Update static-map sample for new API

432c0fb

Add renderer property to layer

4835323

Add missing Promise requirement

6f320c1

Add support for drawing tile layers

9bb0215

Add layer opacity support.

829e626

Add Style Support to GeoJson Conversion

1baea73

Montage Geo extends the GeoJson specification by adding an additional style property to feature. If a feature has a style property it is serialized into the GeoJson object and deserialized when read in.

Add feature drawing support to static map

d644e79

The static map now draws features if the layer being drawn has a feature collection property.

StaticMap's basemap now uses TileDelegate

2bb09bc

Set line width for static map lines & polygons

c63b31c

Remove reference to unused anchor

Reset static map opacity before feature drawing

43cda27

Change logic for positiong icons in static map

60fdd3f

Icons are now positioned from their top left corner (like the HTML 5 canvas API) instead of its center.

Loading large map images instead of tiles for supported protocols

d7367f5

Fix Tile.fromCoordinates bug at anti-meridian

0c70d4d

Simplify projectMercatorOntoCanvas logic

9c00ced

Fix icon anchor handling

e806970

Fix incorrect map image drawing size

6580d93

The actual image of a MapImage may be smaller than the MapImage's size, e.g. when the image service returns a smaller image than what was specified due to exceeding max export size limits.

...

18d2b5e

New Image Overlay Start

9cff4b2

Start refactoring tile overlays

7ea22b3

johnnykahalawai and others added 22 commits August 13, 2021 13:46

Remove and rename map image overlay components

97838cf

Merge into previous

a44b8de

Add Ability to Fetch Layers

0db5249

Layers are fetched through montage-data service by making a fetch for Layer with a criteria that includes the Protocol and source URL. Intern- ally the layer service delegates the fetch to a child service special- ized for that protocol.

...

bf9caaf

Start work on Feature Service

2925fd7

WIP FeatureCollectionOverlay

90b9cc0

WIP - Add default FeatureDelegate instance. FeatureDelegate is untested

ff0c973

to be squashed

0a11e53

Fix MapImageOverlay behavior

294a355

- Call super in constructor - Update images on map move

Fix typos in comments

7b87ae8

Improve layer support in FeatureCollectionOverlay

cea2d42

Create a collection in FeatureCollectionOverlay if a layer is assigned and store the fetched features in that collection.

Remove "remove symbol" logging

b60f3fb

Logging for each symbol negatively affects performance when removing a layer with many features.

WIP Implement FeatureService

a8d1bb8

Add press event to map & leaflet engine

6d6af32

WIP -- Default feature and layer service

9a4de7f

Add support for different lifecycles to FeatureCollectionOverlay

af29ed1

FeatureCollectionOverlay assumed that it had a map when it received a collection. This commit allows the developer to assign the collection to the overlay before it is added to the map.

Document map press events

a696356

Add null check to FeatureCollectionOverlay

9be84f6

Draw features when FeatureCollectionOverlay is added to map

c159587

Support registering new protocols

6e4ee55

Improve assignment of _supportedImageFormats

7fa64e6

tejaede requested a review from johnnykahalawai September 21, 2021 15:46

tejaede self-assigned this Sep 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for registering new protocol #9

Add support for registering new protocol #9

tejaede commented Sep 21, 2021

Add support for registering new protocol #9

Are you sure you want to change the base?

Add support for registering new protocol #9

Conversation

tejaede commented Sep 21, 2021