From 808a2d1908088137a16d086dd86802ece7bd13b3 Mon Sep 17 00:00:00 2001 From: Scott Rigby Date: Wed, 12 Jan 2022 17:59:56 -0500 Subject: [PATCH] Change underscore (_) back to plus (+) for Helm Signed-off-by: Scott Rigby --- internal/experimental/registry/client.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/experimental/registry/client.go b/internal/experimental/registry/client.go index 2de348ccd63..1b686b8baed 100644 --- a/internal/experimental/registry/client.go +++ b/internal/experimental/registry/client.go @@ -604,7 +604,9 @@ func (c *Client) Tags(ref string) ([]string, error) { var tagVersions []*semver.Version for _, tag := range registryTags { - tagVersion, err := semver.StrictNewVersion(tag) + // Change underscore (_) back to plus (+) for Helm + // See https://github.com/helm/helm/issues/10166 + tagVersion, err := semver.StrictNewVersion(strings.ReplaceAll(tag, "_", "+")) if err == nil { tagVersions = append(tagVersions, tagVersion) }