Started work on 'helm pull'

Signed-off-by: Andrew Block <andy.block@gmail.com>
monostream · Jan 12, 2022 · 4f62d3d · 4f62d3d
1 parent df98e18
commit 4f62d3d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/internal/resolver/resolver.go b/internal/resolver/resolver.go
@@ -18,7 +18,6 @@ package resolver
 import (
 	"bytes"
 	"encoding/json"
-	"fmt"
 	"os"
 	"path/filepath"
 	"strings"
@@ -137,7 +136,6 @@ func (r *Resolver) Resolve(reqs []*chart.Dependency, repoNames map[string]string
 			}
 			found = false
 		} else {
-			fmt.Println("Entering OCI block")
 			version = d.Version
 			if !FeatureGateOCI.IsEnabled() {
 				return nil, errors.Wrapf(FeatureGateOCI.Error(),

diff --git a/pkg/action/pull.go b/pkg/action/pull.go
@@ -92,13 +92,13 @@ func (p *Pull) Run(chartRef string) (string, error) {
 	}
 
 	if registry.IsOCI(chartRef) {
-		if p.Version == "" {
-			return out.String(), errors.Errorf("--version flag is explicitly required for OCI registries")
-		}
-
 		c.Options = append(c.Options,
-			getter.WithRegistryClient(p.cfg.RegistryClient),
-			getter.WithTagName(p.Version))
+			getter.WithRegistryClient(p.cfg.RegistryClient))
+
+		if p.Version != "" {
+			c.Options = append(c.Options,
+				getter.WithTagName(p.Version))
+		}
 	}
 
 	if p.Verify {