Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too strict requirement on scipy #570

Open
lexming opened this issue Dec 12, 2024 · 4 comments
Open

Too strict requirement on scipy #570

lexming opened this issue Dec 12, 2024 · 4 comments

Comments

@lexming
Copy link

lexming commented Dec 12, 2024

This requirement on scipy is too strict and makes it hard to package climate_indices with other software as it forces this single version of scipy into the environment. Please change it to a minimum version requirement like it is already done for the other requirements:

scipy = '1.10.1'

On a side note, it would be also convenient to tag the commits that correspond to the versions released on PyPI. Then it would be straightforward to know which commit corresponds to each version and download the corresponding sources from github if needed.

@monocongo
Copy link
Owner

I have a PR which changes various dependency versions for support of the latest (Python 3.13) but it will cause a loss of support for Python 3.8 and 3.9 since it requires a recent version of scipy that only supports Python>=3.10. If you can please comment there or submit another PR with versions worked out to your satisfaction. My goal is to support as many versions of Python as possible and for the package to play well with others. I'm no expert at packaging so I'm happy to take suggestions. Thanks in advance, I appreciate your help!

@monocongo
Copy link
Owner

See #569

@lexming
Copy link
Author

lexming commented Dec 13, 2024

The version requirements in #569 look fine. Thanks!
Loosing support for Python 3.8 and 3.9 is not a problem for us, those are quite old already. It is more important that we can install climate_indices alongside other Python packages, in whichever version of Python we use.

@monocongo
Copy link
Owner

Thanks for looking that over, @lexming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants