-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind Skottie's Animation Builder #2630
Conversation
@mattleibow When is this going to released? |
ce6f35c
to
b114fdb
Compare
Hi @mattleibow any idea when will it be released? i have done migration of an app and i am only blocked by lottie animations which uses files. if there is not plan for release, then will it be fine if i just checkout this branch and create build and use the dlls? i only need it for ios and android |
b114fdb
to
e0aef33
Compare
7d5ae04
to
b127cd3
Compare
[Trait(Traits.FailingOn.Key, Traits.FailingOn.Values.macOS)] // Something with sk_sp<SkPicture> SkDrawable::onMakePictureSnapshot() is causing issues | ||
[Trait(Traits.FailingOn.Key, Traits.FailingOn.Values.iOS)] // Something with sk_sp<SkPicture> SkDrawable::onMakePictureSnapshot() is causing issues | ||
[Trait(Traits.FailingOn.Key, Traits.FailingOn.Values.MacCatalyst)] // Something with sk_sp<SkPicture> SkDrawable::onMakePictureSnapshot() is causing issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that the fact I override the
sk_sp<SkPicture> SkDrawable::onMakePictureSnapshot()
function in C++ for the managed drawable is causing a crash. If i change it to
SkPicture* SkDrawable::onMakePictureSnapshot()
stops the crash. I noticed this locally on macOS. Not sure why it passes on CI.
Issue: #2760
|
||
namespace SkiaSharp.Resources | ||
{ | ||
public abstract unsafe class ResourceProvider : SKObject, ISKReferenceCounted, ISKSkipObjectRegistration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to future self. Don't forget to correctly apply the ISKReferenceCounted
interface and NOT explicitly delete the reference counted types. This causes a hard-to-debug crash because the type is deleted while in use. Ot sometimes crashes in a debug build with a better log message, but not often.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.x release/2.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.x
# Create a new branch
git switch --create backport/pr-2630-to-release/2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 42fc0181e0f9d2cda2d7f4f9359de2dd5252fcc1
# Push it to GitHub
git push --set-upstream origin backport/pr-2630-to-release/2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.x Then, create a pull request where the |
Description of Change
This PR adds a few of the essential APIs to enable loading embedded files in the Lottie animation. Currently, there is just the support for file-based and data URI-based assets.
Bugs Fixed
API Changes
Behavioral Changes
None.
Required skia PR
mono/skia#114
PR Checklist