Avoid adding the version attribute to deleted docs #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2020 11:11
I had to relax a couple of the rubocop constraints in order to fit these changes in. Also, there was another change in integration_spec.rb that appears unrelated. After making the change in trackable.rb, the specs started failing because, while the #history_tracks method was returning a new array with an additional member, the #last method was continuing to return the same record. Addressing the last member of the array by index avoids the issue.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to this PR.
Adding the version attribute to a deleted embedded document is causing an update conflict, which mongoid ultimately applies after the removal of the document, creating an empty document with only the version attribute.
I had to relax a couple of the rubocop constraints in order to fit these changes in.
Also, there was another change in integration_spec.rb that appears unrelated. After making the change in trackable.rb, the specs started failing because, while the
history_tracksmethod was returning a new array with an additional member, thelastmethod was continuing to return the same record. Addressing the last member of the array by index avoids the issue.