Add Mongoid 7.1 configuration to Travis #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Add to README that mongoid 7.1 is supported and a changelog line "Support mongoid 7.1", please? |
dblock
reviewed
Jun 11, 2020
| @@ -12,7 +12,8 @@ env: | |||
| - MONGOID_VERSION=4 | |||
| - MONGOID_VERSION=5 | |||
| - MONGOID_VERSION=6 | |||
| - MONGOID_VERSION=7 | |||
| - MONGOID_VERSION=70 | |||
There was a problem hiding this comment.
If I were to nitpick, we can just do exact things here, e.g. 7.0 and 7.1, then in Gemfile when '7.1' instead of the regex. Seems unnecessarily complicated. We could maybe even write "~> 7.0.0" here and simplify the whole thing. Not a must, happy with this too.
|
Okay I did that. |
|
Looks like for 7 you forgot to modify .travis.yml so build is failing. Also how did you get a 1-letter Github username?!!!! ;) |
|
Resolved in #251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.