Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 2.7 keyword argument warnings #236

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Fix Ruby 2.7 keyword argument warnings #236

merged 1 commit into from
Mar 31, 2020

Conversation

vasil-nesterov
Copy link
Contributor

@vasil-nesterov vasil-nesterov commented Mar 29, 2020

This PR fixes Ruby 2.7 keyword argument warnings.

./mongoid-history-0.8.2/lib/mongoid/history/trackable.rb:28: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
./activemodel-6.0.2.2/lib/active_model/callbacks.rb:138: warning: The called method is defined here
./mongoid-history-0.8.2/lib/mongoid/history/trackable.rb:29: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
./activemodel-6.0.2.2/lib/active_model/callbacks.rb:138: warning: The called method is defined here
./mongoid-history-0.8.2/lib/mongoid/history/trackable.rb:30: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
./activemodel-6.0.2.2/lib/active_model/callbacks.rb:138: warning: The called method is defined here

@mongoid-bot
Copy link

mongoid-bot commented Mar 29, 2020

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@coveralls
Copy link

coveralls commented Mar 29, 2020

Coverage Status

Coverage increased (+0.3%) to 98.645% when pulling d9acabb on vasilysn:fix-ruby-27-warnings into 51b1e98 on mongoid:master.

@dblock dblock merged commit 3f98e77 into mongoid:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants