Add spec proving #225 is fixed by #227. #229
Conversation
Here's an example of a CHANGELOG.md entry: * [#229](https://github.com/mongoid/mongoid-history/pull/229): Add spec proving #225 is fixed by #227 - [@jnfeinstein](https://github.com/jnfeinstein).Generated by 🚫 danger |
Generated by 🚫 danger |
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ### 0.8.2 (Next) | |||
|
|
|||
| * [#227](https://github.com/mongoid/mongoid-history/pull/227): Store options in inheritable class attributes - [@jnfeinstein](https://github.com/jnfeinstein). | |||
| * [#229](https://github.com/mongoid/mongoid-history/pull/229): Add spec proving #225 is fixed by #227 - [@jnfeinstein](https://github.com/jnfeinstein). | |||
There was a problem hiding this comment.
Generally no need a changelog for spec, but change this into "Fixed inheritance of history_trackable_options." and link to #225.
There was a problem hiding this comment.
Danger wont pass without it. What's the fix?
spec/unit/trackable_spec.rb
Outdated
| @@ -802,4 +802,38 @@ class Fish | |||
| end.to change(Tracker, :count).by(1) | |||
| end | |||
| end | |||
|
|
|||
| context "extending a #{Mongoid::History::Trackable}" do | |||
There was a problem hiding this comment.
You didn't mean #{} I think.
There was a problem hiding this comment.
I did. I should have used described_class, I'll fix that. This makes the output independent of the classname in case it's ever changed.
|
Danger is rightfully complaining about the extra period on your changelog line :) |
|
For multiple referenced issues we comma-separate them: |
`context` is more consistent for a non-method spec.
|
@dblock updated and passed CI. |
|
Merged |
|
@dblock shall I release 0.8.2? |
|
Don't wait for my permission @jnfeinstein, maintainers release at will, amen. |
|
@dblock thanks for the vote of confidence. Sorry for delay, was actually vacationing in NYC. Any concerns about this being a breaking change? Anybody relying on this bug for configuration could be surprised by the change. However it would also correct the configuration that they would have correctly mis-configured. I could see it being 0.8.3 or 0.9.0. |
|
Feel free to PR a paragraph for https://github.com/mongoid/mongoid-history/blob/master/UPGRADING.md with a 0.9.0 version bump, your call. |
No description provided.