-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store options in inheritable class attributes. #227
Conversation
Rubocop is throwing two errors on lines I didn't change. Not sure what to do with those. |
For rubocop run |
This is straightforward, I love it. It's a great incremental step on top of #208, I should have totally done that. |
Optional/next steps: do we need Make sure to update CHANGELOG and fix rubocop and it's good to go! |
This fixes issue #226. Underlying cause is that the options were being keyed on collection name, which is able to be changed. This change stores the options on the class itself where it will always be available regardless of collection name.
This should reduce build times.
@dblock this PR has been updated per your suggestions. I added a commit that allows Travis to use the latest prebuilt ruby in the 2.3 tree. This knocks off ~18s per build. I can open a separate PR for this if that's preferred. |
@jnfeinstein Merged, much thanks. You seem to know what you're doing :) Want to help out with the maintenance of mongoid-history? If yes you can make the next release and I'll gladly add you to rubygems (what's your email?). |
Thanks. I'm happy to help out when I can. |
Thanks! Care to email me your rubygems.org email? |
This fixes issue #226. Underlying cause is that the options were
being keyed on collection name, which is able to be changed.
This change stores the options on the class itself where it will
always be available regardless of collection name.