Small refactor of relations. #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
refactor-relations
branch
from
5ebb14b to
cf25e06
Compare
dblock
force-pushed
the
refactor-relations
branch
from
cf25e06 to
5308b65
Compare
mikwat
approved these changes
Jan 16, 2018
| # @return [ nil | Constant ] Type of relation. | ||
| def relation_of(field) | ||
| meta = meta_of(field) | ||
| meta ? meta.relation : nil |
There was a problem hiding this comment.
Since we have a dependency on activesupport, would it be safe to use meta.try(:relation) here?
There was a problem hiding this comment.
It would, but it would hide any exception such as the method .relation no longer exists.
There was a problem hiding this comment.
Good point. Too bad we can't rely on Ruby 2.3 safe navigation operator &. yet.
Here's an example of a CHANGELOG.md entry: * [#216](https://github.com/mongoid/mongoid-history/pull/216): Small refactor of relations - [@dblock](https://github.com/dblock).Generated by 🚫 danger |
|
Changes Unknown when pulling 5308b65 on dblock:refactor-relations into ** on mongoid:master**. |
1 similar comment
|
Changes Unknown when pulling 5308b65 on dblock:refactor-relations into ** on mongoid:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking some of the working parts out of #215.
Extracts
increment_current_version.Simplifies fetching of the relation's class or type of relationship by always looking at
reflect_on_associationand memoizing the result.Collapses
embeds_many_classandembeds_one_classintorelation_class_of.Renames methods from embedded to related so we can continue extending into many-to-many and such.