Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support :if and :unless for track_history callbacks #212

Merged
merged 3 commits into from
Dec 8, 2017

Conversation

jagdeepsingh
Copy link
Contributor

@jagdeepsingh jagdeepsingh commented Dec 6, 2017

Raised for #209 with RSpecs here.

@coveralls
Copy link

coveralls commented Dec 6, 2017

Coverage Status

Coverage decreased (-1.0%) to 98.806% when pulling 647f606 on JagdeepSingh:conditional-if-unless-options into d6102a1 on mongoid:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 99.767% when pulling 647f606 on JagdeepSingh:conditional-if-unless-options into d6102a1 on mongoid:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 99.767% when pulling 647f606 on JagdeepSingh:conditional-if-unless-options into d6102a1 on mongoid:master.

@coveralls
Copy link

coveralls commented Dec 6, 2017

Coverage Status

Coverage increased (+0.007%) to 99.767% when pulling 647f606 on JagdeepSingh:conditional-if-unless-options into d6102a1 on mongoid:master.

@johnnyshields
Copy link
Member

johnnyshields commented Dec 6, 2017

@dblock I'd appreciate if you can take a moment to merge 212, 211, and 210 and ideally cut a release. Both Jagdeep and myself have reviewed these.

@dblock
Copy link
Collaborator

dblock commented Dec 7, 2017

Done. And this looks great, rebase/merge along.

@johnnyshields
Copy link
Member

@jagdeepsingh please handle

@jagdeepsingh
Copy link
Contributor Author

This will be conflicted again after merging #211. Will rebase it then.

@jagdeepsingh jagdeepsingh force-pushed the conditional-if-unless-options branch from 647f606 to dcdf689 Compare December 8, 2017 12:38
@coveralls
Copy link

coveralls commented Dec 8, 2017

Coverage Status

Coverage increased (+0.006%) to 99.803% when pulling dcdf689 on JagdeepSingh:conditional-if-unless-options into f9880c7 on mongoid:master.

@jagdeepsingh
Copy link
Contributor Author

Rebased to latest master. @dblock Please merge.

@dblock dblock merged commit e5a6f77 into mongoid:master Dec 8, 2017
@dblock
Copy link
Collaborator

dblock commented Dec 8, 2017

Great, merged.

@johnnyshields
Copy link
Member

@dblock thanks for all your help. Can I ask you to cut an official release?

@dblock
Copy link
Collaborator

dblock commented Dec 8, 2017

I can try to get to it in the next day or so, otherwise you can cut one too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants