Enable history tracking on create and destroy by default #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jagdeepsingh
force-pushed
the
johnnyshields-patch-1
branch
from
5d8070b to
5999f6d
Compare
dblock
approved these changes
Dec 7, 2017
CHANGELOG.md
Outdated
|
|
||
| * [#208](https://github.com/mongoid/mongoid-history/pull/208): Fix: history tracks fields declared after `track_history` - [@mikwat](https://github.com/mikwat). | ||
| * [#211](https://github.com/mongoid/mongoid-history/pull/211): BREAKING CHANGE - Enable tracking create/destroy by default - [@jagdeepsingh](https://github.com/jagdeepsingh). |
There was a problem hiding this comment.
Lets not be dramatic :) It's not a breaking change, it's just a different behavior. I would just remove the BREAKING CHANGE part and call it a day.
spec/unit/trackable_spec.rb
Outdated
| @@ -613,6 +615,7 @@ def self.name | |||
| let(:m) { MyModel.create!(foo: 'bar') } | |||
|
|
|||
| it 'should create history' do | |||
| m # Created | |||
There was a problem hiding this comment.
Instead use let!, it will create m.
|
@jagdeepsingh please handle |
jagdeepsingh
force-pushed
the
johnnyshields-patch-1
branch
from
5999f6d to
ac108d4
Compare
2 similar comments
|
@dblock done. |
|
@dblock please merge |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump next version to 0.8.0
This is a replacement for #207.