-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix rpdk configs for new cloudformation cli versions #881
Conversation
This reverts commit 1253ab7.
|
||
debug: | ||
@echo "==> Building handler binary for debugging" | ||
cfn generate | ||
env GOOS=$(goos) CGO_ENABLED=$(cgo) GOARCH=$(goarch) go build -gcflags="$(DEBUG_FLAGS)" -ldflags="$(LINKER_FLAGS)" -tags="$(tags)" -o bin/handler cmd/main.go | ||
env GOOS=$(goos) CGO_ENABLED=$(cgo) GOARCH=$(goarch) go build -gcflags="$(DEBUG_FLAGS)" -ldflags="$(LINKER_FLAGS)" -tags="$(tags)" -o bin/bootstrap cmd/main.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating to work with latest versions of cloudformation-cli-go-plugin as per aws-cloudformation/cloudformation-cli#1053 (comment)
Currently this is resulting in errors when trying to submit resource to private registry and manually creating a stack [Lambda function handler threw an uncaught exception: fork/exec /var/task/handler: no such file or directory
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to reproduce this error. As a follow-up change I also had to adjust entrypoint
and testEntrypoint
in .rpdk-config file to bootstrap
and this way I was able to submit a resource to the private registry and create a stack successfully.
This reverts commit c7c7bbc.
…y point, all adjusting all resources
@@ -9,11 +9,11 @@ ldXflagsD=-s -w -X github.com/mongodb/mongodbatlas-cloudformation-resources/util | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not changed in this PR but in case you can do it here, all ldXflagsD (debug) must not have -s -w, an example would be:
ldXflagsD=-X github.com/mongodb/mongodbatlas-cloudformation-resources/util.defaultLogLevel=debug -X github.com/mongodb/mongodbatlas-cloudformation-resources/version.Version=${CFNREP_GIT_SHA}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for suggestion, adjusted.
can we add/change some doc with the expected cfn cli versions? |
26a9aed
Proposed changes
Jira ticket: CLOUDP-220385
This PR updates import path setting in rpdk config of various resources to support newer versions of
cloudformation-cli-go-plugin
as per aws-cloudformation/cloudformation-cli#1054 (comment)EDIT (Agustin): As a followup to this draft pull request, I was able to identifying missing changes in the .rpdk-config files and verified the change by creating a stack after publishing a private resource with the latest config changes. Used the following examples project as reference: https://github.com/aws-cloudformation/cloudformation-cli-go-plugin/tree/master/examples/github-repo
This PR will unblock us from developing with latest cloudformation cli versions, which in turn is also used in our publishing workflow.
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmt
and formatted my codeworks in Atlas
Further comments