DOCSP-38327: add Query Builder examples to usage examples #3259
+983
−401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
force-pushed
the
DOCSP-38327-add-qb-to-ues
branch
from
e877a17 to
111b290
Compare
rustagir
force-pushed
the
DOCSP-38327-add-qb-to-ues
branch
from
9fa735d to
f498f97
Compare
GromNaN
changed the title
jordan-smith721
approved these changes
Jan 31, 2025
docs/usage-examples/insertMany.txt
Outdated
| - Inserts documents into the ``movies`` collection | ||
| - Prints whether the insert operation succeeds | ||
|
|
||
| The example calls the ``insert()`` method to insert documents that model |
There was a problem hiding this comment.
"model" here confused me here for a minute, I think because I was thinking "a model object" based on the previous bullets
Suggested change
| The example calls the ``insert()`` method to insert documents that model | |
| The example calls the ``insert()`` method to insert documents that represent |
docs/usage-examples/insertMany.txt
Outdated
| - Inserts documents into the ``movies`` collection | ||
| - Prints whether the insert operation succeeds | ||
|
|
||
| The example calls the ``insert()`` method to insert documents that model |
There was a problem hiding this comment.
Suggested change
| The example calls the ``insert()`` method to insert documents that model | |
| The example calls the ``insert()`` method to insert documents that represent |
docs/usage-examples/updateOne.txt
Outdated
| - ``where()``: Matches documents in which the value of the | ||
| ``title`` field is ``"Carol"`` | ||
| - ``orderBy()``: Sorts matched documents by their ascending ``_id`` values | ||
| - ``first()``: Retrieves only the first matching document. |
There was a problem hiding this comment.
Suggested change
| - ``first()``: Retrieves only the first matching document. | |
| - ``first()``: Retrieves only the first matching document |
GromNaN
reviewed
Jan 31, 2025
| $movies = Movie::where('runtime', '>', 900) | ||
| ->orderBy('_id') | ||
| ->get(); | ||
| // end-find | ||
| // end-eloquent-find |
There was a problem hiding this comment.
You must keep the previous assertion, otherwise your query is not tested.
Suggested change
| // end-eloquent-find | |
| // end-eloquent-find | |
| $this->assertEquals(2, $movies->count()); |
There was a problem hiding this comment.
I'll go through an re-add the tests where I missed them!
rustagir
force-pushed
the
DOCSP-38327-add-qb-to-ues
branch
from
c047dec to
e6136c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DOCSP-38327
adds query builder code examples to usage examples
STAGING - click through each usage example that was changed
Checklist