Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): bump driver to 6.14.2, libmongocrypt to 1.13.0 MONGOSH-2037 MONGOSH-2038 #2393

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Mar 4, 2025

Includes support for $lookup (e2e test TBD until COMPASS-8816, will likely need to wait for 8.1 release) and an OIDC connection fix

@@ -23897,6 +23898,12 @@
"node": ">=10"
}
},
"node_modules/prebuild-install/node_modules/napi-build-utils": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge deal, but it looks like we now have duplication of prebuild-install and napi-build-utils because of the different versions being requested by kerberos and mongodb-client-encryption. Might be a good idea to dedupe them if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it alright if I promise to do https://jira.mongodb.org/browse/MONGOSH-1881 right after this PR? 😅

That should result in deduplicating these dependencies, but the kerberos bump doesn't contain any features/fixes we want to get out, whereas this one does, and I'd rather not discover that bumping kerberos is still broken for us just to go back to the original version 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it's a pinky promise, we can let this one slide 😆

@addaleax addaleax changed the title feat(deps): bump driver to 6.14.1, libmongocrypt to 1.13.0 MONGOSH-2037 MONGOSH-2038 feat(deps): bump driver to 6.14.2, libmongocrypt to 1.13.0 MONGOSH-2037 MONGOSH-2038 Mar 4, 2025
@addaleax addaleax merged commit 9e07d34 into main Mar 4, 2025
126 of 128 checks passed
@addaleax addaleax deleted the driver-6.14.1 branch March 4, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants