fix(tests): update VSCode runner to use 24.04 #2344
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 3, 2025
gagik
force-pushed
the
gagik/fix-vscode
branch
from
13cd9c3 to
a485f2a
Compare
addaleax
reviewed
Feb 25, 2025
| (cd scripts/docker && docker build -t ubuntu24.04-xvfb -f ubuntu24.04-xvfb.Dockerfile .) | ||
| apt list --installed | ||
| sudo apt-get update | ||
| sudo apt-get install -y curl=7.68.0-1ubuntu2.22 libcurl4=7.68.0-1ubuntu2.22 libcurl4-openssl-dev=7.68.0-1ubuntu2.22 |
There was a problem hiding this comment.
Were these lines supposed to go into the dockerfile config? Because otherwise this here would be affecting the global scope of the evergreen host, which we'd almost never want to do
There was a problem hiding this comment.
yeah, not meant to be here it's actually leftover from previous evergreen.yml.in.
Good reminder that evergreen maintains state though, that's one thing I find weird coming from GitHub Actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be related to mongodb-js/vscode#910
An attempt to fix the test by doing this.
Doesn't seem to work thus far. The error can be re-created locally when running inside the Ubuntu docker. The tests pass on Mac so the issue seems platform-specific.