Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Re-structure the repository as monorepo #363

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

wakamsha
Copy link
Contributor

@wakamsha wakamsha commented Feb 8, 2025

What changed / motivation ?

What changed?

Re-architecture this repository as a monorepo, so that musltiple frontend tools such as eslint-config-moneyforward can be managed.

What motivation?

We'd like to develop @moneyforward/stylelint-config, but if we start by creating a new repo, the initial costs of building release workflows and setting up Renovate, as well as the subsequent maintenance costs, would be huge burden; we'd like to reuse exist ecosystems as much as possible.

Linked PR / Issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Chore (routine task, maintenance, or non-functional change that doesn't modify src or test files)

Pre-flight checklist

References

@wakamsha wakamsha self-assigned this Feb 8, 2025
"./test/*": "./configs/eslintrc/test/*.js",
"./typescript": "./configs/eslintrc/typescript.js"
},
"name": "frontend-tools",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this PR is merged, change the name of this repo to frontend-tools.

"configs",
"rules"
],
"packageManager": "pnpm@9.15.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Node Package Manager to pnpm for easy maintenance of monorepo.

@wakamsha wakamsha force-pushed the chore/reconstruction-as-monorepo branch from dcac741 to 5786dc7 Compare February 8, 2025 07:41
@wakamsha wakamsha marked this pull request as draft February 8, 2025 07:48
@wakamsha wakamsha marked this pull request as ready for review February 8, 2025 07:48
@wakamsha
Copy link
Contributor Author

wakamsha commented Feb 8, 2025

Tasks after monorepo

  • rename this repository
  • retouch the latest release tag

@wakamsha wakamsha force-pushed the chore/reconstruction-as-monorepo branch from 806df25 to 6f3f8f9 Compare February 10, 2025 03:47
@wakamsha wakamsha requested a review from tongari07 February 10, 2025 03:49
Copy link
Contributor

@tongari07 tongari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@wakamsha wakamsha merged commit a06a1bb into main Feb 10, 2025
2 checks passed
@wakamsha wakamsha deleted the chore/reconstruction-as-monorepo branch February 10, 2025 04:01
@oss-frontend-github-app
Copy link

🎉 This PR is included in version eslint-config-moneyforward-v5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants