feat: Implement v3 rule "next" #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakamsha
commented
Mar 12, 2024
| @@ -29,7 +30,6 @@ | |||
| "eslint-plugin-jest-dom": "^4.0.3", | |||
| "eslint-plugin-jsx-a11y": "^6.8.0", | |||
| "eslint-plugin-n": "^16.6.2", | |||
| "eslint-plugin-next": "^0.0.0", | |||
There was a problem hiding this comment.
It seems that it was probably installed by mistake.
https://www.npmjs.com/package/eslint-plugin-next
taigakiyokawa
requested changes
Mar 12, 2024
|
yes, that will be set in |
taigakiyokawa
approved these changes
Mar 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
# [3.0.0](2.0.0...3.0.0) (2024-04-18) ### Bug Fixes * Allow to omit importing some functions for test files written in TypeScript ([#250](#250)) ([7da21e3](7da21e3)) ### Features * Implement CD "release" ([#255](#255)) ([66734d1](66734d1)) * Implement config "node" ([#244](#244)) ([170e699](170e699)) * Implement config "react" ([#240](#240)) ([a8908d6](a8908d6)) * Implement config `jsdoc` ([#238](#238)) ([24cdd78](24cdd78)) * Implement the rule "best-practices" ([#210](#210)) ([701a0e6](701a0e6)) * Implement the rule "errors" ([#211](#211)) ([907c92a](907c92a)) * Implement the rule "es6" ([#212](#212)) ([31e3000](31e3000)) * Implement the rule "imports" ([#213](#213)) ([b09c196](b09c196)) * Implement the rule "react-hooks" ([#226](#226)) ([d1e574d](d1e574d)) * Implement the rule "style" ([#216](#216)) ([6d2261d](6d2261d)) * Implement the rule "variables" ([#222](#222)) ([e91e5d2](e91e5d2)) * Implement v3 config "essentials" ([#237](#237)) ([af7c775](af7c775)) * Implement v3 config "next" ([#243](#243)) ([00fdb4d](00fdb4d)) * Implement v3 config "storybook" ([#241](#241)) ([bca4534](bca4534)) * Implement v3 config "test/react" ([#239](#239)) ([e488f4a](e488f4a)) * Implement v3 config "typescript" ([#242](#242)) ([eb3d1e4](eb3d1e4)) * Implement v3 rule "jesdoc" ([#234](#234)) ([b407ee3](b407ee3)) * Implement v3 rule "jest-dom" ([#231](#231)) ([e0891ed](e0891ed)) * Implement v3 rule "jest" ([#228](#228)) ([d544fa0](d544fa0)) * Implement v3 rule "next" ([#227](#227)) ([b1662ad](b1662ad)) * Implement v3 rule "node" ([#215](#215)) ([91bcb4c](91bcb4c)) * Implement v3 rule "promise" ([#223](#223)) ([b79e339](b79e339)) * Implement v3 rule "testing-library" ([#232](#232)) ([6afbe8f](6afbe8f)) * Implement v3 rule "typescript" ([#236](#236)) ([6d42dc6](6d42dc6)) * Implement v3 rule `jsx-a11y` ([#224](#224)) ([7fe1bd4](7fe1bd4)) * Implement v3 rule `react` ([#225](#225)) ([fe33aa2](fe33aa2)) * Implement v3 rule storybook ([#233](#233)) ([d879dc5](d879dc5)) ### BREAKING CHANGES * * Linter rules have been significantly added and are now more strict. * The way `eslintrc` is configured has been changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the ruleset based on eslint-plugin-next recommend ruleset and core-web-vitals ruleset.
I've determined that these rulesets are sufficient on their own, so I don't configure any additional settings.
This ruleset depends on @next/eslint-plugin-next.
References