Fix build with boost ASIO 1.87. Support boost 1.66+ [0.18] #9800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to fail to compile, is a commit missing that we had on master? |
tobtoht
reviewed
Feb 14, 2025
tobtoht
reviewed
Feb 14, 2025
Something does appear missing, but I'm not sure what it is at first glance. This does compile on my local macOS machine with Boost 1.87. But I'm not using the CI script to build, so I have to figure out what's different. |
tobtoht
reviewed
Feb 14, 2025
vtnerd
force-pushed
the
fix/boost_1.87_0.18
branch
from
6452172 to
01bcd52
Compare
tobtoht
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #9628 but on release branch.