Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete goals: slurp-no-updates #532

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Delete goals: slurp-no-updates #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/ontology/mondo-ingest.Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,19 +527,10 @@ slurp-%: slurp/%.tsv
slurp-ordo: slurp/ordo.tsv
$(MAKE) slurp-modifications-ordo

.PHONY: slurp-no-updates-%
slurp-no-updates-%: slurp/%.tsv
@echo "$@ completed".

.PHONY: slurp-docs
slurp-docs:
python3 $(SCRIPTSDIR)/migrate.py --docs

.PHONY: slurp-all-no-updates
slurp-all-no-updates: $(foreach n,$(ALL_COMPONENT_IDS), slurp-no-updates-$(n))
$(MAKE) slurp-modifications
@echo "$@ ($^) completed".
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletion of unused goals

Deletes:

  • slurp-all-no-updates
  • slurp-no-updates-%

Thes currently do the exact same thing as slurp-all and slurp-%. They're not called by any other goals, so they're useless.

I am trying to remember what these goals were originally for.

It may be that they were a variation of running the slurp that did not involve doing some pip installs beforehand. The pip install would have been because ODK did not have high enough versions of some libraries at the time, likely OAK or maybe sssom-py.

I also have some recollection of -B being part of / necessary for some goal, maybe for part of the slurp pipeline, and this -no-updates variation would have been the same thing, but without -B.

Either way, whatever purpose they had appears to no longer be valid. They're doing nothing here, so I'm deleting them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip build QC for this one?

This seems like a good case of skipping the need to run a build, because nowhere in build-mondo-ingest are these goals called. Deletion of them should have no effect on the build.


.PHONY: slurp-all
slurp-all: $(foreach n,$(ALL_COMPONENT_IDS), slurp-$(n))
$(MAKE) slurp-modifications
Expand Down