Delete goals: slurp-no-updates

[joeflack4]

Overview

Deletes some unused goals which add no additional functionality.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

• Yes
• No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

• Yes
• No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

• Yes, requirements.txt.full was updated and an ODK issue submitted
• No

Were any other non-Python packages added?

• Yes, Dockerfile updated and an ODK issue submitted
• No

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

• Yes

[joeflack4]

Deletion of unused goals

Deletes:

• slurp-all-no-updates
• slurp-no-updates-%

Thes currently do the exact same thing as slurp-all and slurp-%. They're not called by any other goals, so they're useless.

I am trying to remember what these goals were originally for.

It may be that they were a variation of running the slurp that did not involve doing some pip installs beforehand. The pip install would have been because ODK did not have high enough versions of some libraries at the time, likely OAK or maybe sssom-py.

I also have some recollection of -B being part of / necessary for some goal, maybe for part of the slurp pipeline, and this -no-updates variation would have been the same thing, but without -B.

Either way, whatever purpose they had appears to no longer be valid. They're doing nothing here, so I'm deleting them.

[joeflack4]

Skip build QC for this one?

This seems like a good case of skipping the need to run a build, because nowhere in build-mondo-ingest are these goals called. Deletion of them should have no effect on the build.

[matentzn]

If your comments are correct lets merge

[joeflack4]

@matentzn I stand by the comments.
Looks like I need to resolve conflicts before merging.

Just need @twhetzel 's eye. @trish, in summary, this PR removes some goals that are not part of the build and which we really didn't end up using and don't need