Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functions in SlydifiOverlay have counterintuitive names #19

Closed
na4zagin3 opened this issue Jun 20, 2021 · 1 comment
Closed

Some functions in SlydifiOverlay have counterintuitive names #19

na4zagin3 opened this issue Jun 20, 2021 · 1 comment

Comments

@na4zagin3
Copy link
Contributor

The current version has the following conditional functions.
IMO some of them should be renamed.

Name Behavior Proposal
only n n-layer == n keep
elsewhen n not (only n) can we replace this with negate : ('a -> bool) -> 'a -> bool
till n n-layer <= n it's a matter of taste, but why not rename to until to align with Beamer which has \untilSlide
after n n-layer >= n rename to from because “after” is non-inclusive (n-layer > n)
during m n (n-layer >= m) && (n-layer <= n) rename for between because it's more typical.
in-case nlst nlst includes the current layer number n-layer rename for on-slides
@monaqa
Copy link
Owner

monaqa commented Jul 9, 2021

Thank you so much for your suggestion!
We have included the changes you mentioned in the v0.4.0 release.

@monaqa monaqa closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants