Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Legacy Migrations #3

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Conversation

amenocal
Copy link
Contributor

@amenocal amenocal commented Aug 7, 2024

This pull request adds support for legacy migrations, updating dependencies, and refining the migration status categorization to support legacy migrations status

Support for Legacy Migration Monitoring:

  • Added a new flag --legacy to the command-line interface for monitoring legacy migrations (cmd/root.go). [1] [2] [3]
  • Introduced new environment variables and configuration bindings to support legacy migrations (cmd/root.go).
  • Implemented new functions GetLegacyMigrations and newGHRestClient to handle legacy migration data (internal/api/api.go). [1] [2]

Documentation Updates:

  • Updated usage instructions to reflect the new command gh migration-monitor and added an example with an illustrative image (README.md).

Migration State Handling:

  • Expanded the list of recognized migration states to provide more granular monitoring (internal/migration/migration.go).

Dependency Updates:

  • Updated golang.org/x/oauth2 to version 0.8.0 and added several indirect dependencies (go.mod).

Code Refactoring:

  • Added utility functions and types to improve code readability and maintainability (internal/api/api.go). [1] [2]

These changes collectively enhance the functionality, usability, and maintainability of the migration monitoring tool.

Copy link
Collaborator

@antgrutta antgrutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Legacy support!

@amenocal amenocal merged commit 7be1207 into mona-actions:main Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants