Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added billing and shipping address and line items for Payments. #396

Closed
wants to merge 2 commits into from

Conversation

joosttk
Copy link

@joosttk joosttk commented Jan 11, 2025

No description provided.

@janpaepke
Copy link
Collaborator

Thank you for your PR.

We are aware of this discrepancy (there are more) and are currently working on resolving them.
The reason this isn't easy is that there are various inconsistencies in the API Docs regarding which parameters are optional and which are not.

Aside from lacking test updates your PR struggles with the same issue and just making everything optional isn't in line with this SDKs philosophy of type safety (just as an example lines.recurring.interval is optional in your code, but definitely isn't in the API).

We are currently working with mollie to resolve these issues ASAP.
As soon as we do we might update this PR or close and create a new one.

@janpaepke janpaepke mentioned this pull request Jan 23, 2025
@janpaepke
Copy link
Collaborator

replaced by #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants