fix(event-catalog): local emit & broadcast handlers changed from async to event-driven
#1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally and remotely issue moleculerjs#1065" This reverts commit 0ff0f9d.
intech
commented
Jun 6, 2022
| @@ -223,7 +222,8 @@ describe("Test Tracing feature with actions", () => { | |||
| } | |||
| }); | |||
|
|
|||
| await Promise.delay(500); | |||
| // event loop lag <10ms | |||
| await Promise.delay(510); | |||
There was a problem hiding this comment.
I think this issue is the next tick in node v10, and the test fails. The timeout should be 510ms (although it works with 501ms) because the action already has a 500ms timeout.
It is likely that after v10, optimization was carried out for placing events in a queue, and on later versions, the test passed successfully with the same delay of 500 ms.
intech
changed the title
emit & broadcast handlers changed from async to event-drivenemit & broadcast handlers changed from async to event-driven
icebob
reviewed
Jun 20, 2022
| @@ -35,6 +38,20 @@ class EventCatalog { | |||
| this.events = []; | |||
|
|
|||
| this.EndpointFactory = EventEndpoint; | |||
|
|
|||
| this.on("broker.event", ctx => { | |||
There was a problem hiding this comment.
Why we should use an event emitter to call a non-await-ed method? I feel it's too expensive. Not enough just skip the await in the callEventHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Relevant issues
issue#1065
💎 Type of change
🏁 Checklist: