fix: use own object flattening function that supports class objects #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freezystem
changed the title
Freezystem
changed the title
Freezystem
force-pushed
the
fix/useDotNotation-flatten-fn
branch
from
ac63129 to
41d815b
Compare
Freezystem
force-pushed
the
fix/useDotNotation-flatten-fn
branch
from
85cfa95 to
4eb9a95
Compare
icebob
reviewed
Feb 5, 2025
|
|
||
| const { flatten } = require("../../src/utils"); | ||
|
|
||
| if (process.versions.node.split(".")[0] < 14) { |
There was a problem hiding this comment.
not really. it's because node 10 and 12 does not have "crypto" lib in their core but I can remove the UUID from the test.
There was a problem hiding this comment.
I also don't have included ObjectId in the test because I don't wanted to add the mongodb lib as a dependency just for a tiny test.
💡 But I have an idea. I'll create a tiny homemade class that mimics an ObjectId and that will be compatible with all node versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
flatnpm package to replace the flattening function by an homemade one that only flattens plain old javascript objects and let other structures as is.fixes #401