Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node centrality to graph metrics #2618

Merged
merged 11 commits into from
Feb 13, 2025
Merged

add node centrality to graph metrics #2618

merged 11 commits into from
Feb 13, 2025

Conversation

RossKen
Copy link
Contributor

@RossKen RossKen commented Feb 12, 2025

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

Adding node centrality (i.e. normalised node degree) to the existing node metrics table

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter
  • Run the spellchecker (if appropriate)

@RossKen RossKen marked this pull request as ready for review February 13, 2025 10:07
@RossKen RossKen requested review from RobinL and ADBond February 13, 2025 10:07
@RossKen
Copy link
Contributor Author

RossKen commented Feb 13, 2025

Thanks for reviewing @ADBond - I have implemented your changes. Would you mind taking a scan over once the tests pass?

@RossKen RossKen requested a review from ADBond February 13, 2025 14:34
Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, nice one 👍

@RossKen RossKen merged commit 76b8efa into master Feb 13, 2025
30 checks passed
@RossKen RossKen deleted the add_node_centrality branch February 13, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants