Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of duckdb sql gen #2219

Merged
merged 2 commits into from
Jun 24, 2024
Merged

improve performance of duckdb sql gen #2219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f312cab
improve performance of duckdb sql gen
RobinL Jun 23, 2024
57e0929
make compatible with a table being a csv file path
RobinL Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions splink/duckdb/linker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,14 @@ class DuckDBDataFrame(SplinkDataFrame):

@property
def columns(self) -> list[InputColumn]:
d = self.as_record_dict(1)[0]

col_strings = list(d.keys())
return [InputColumn(c, sql_dialect="duckdb") for c in col_strings]
if not hasattr(self, "_columns_cache"):
result = self.linker._con.execute(
f"DESCRIBE (select * from {self.physical_name} limit 1)"
).fetchall()
self._columns_cache = [
InputColumn(col[0], sql_dialect="duckdb") for col in result
]
return self._columns_cache

def validate(self):
pass
Expand Down
Loading