Splink4: Now DBAPI is merged, remove dialect specific docstrings #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinL
changed the title
…ces/splink into dialect_specific_docstrings
RobinL
changed the title
RossKen
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API is now the same irrespective of which dialect you use, so the dialect specific docstrings are no longer required
I've left them in for the various labels methods, because they require registration of a table, and it's not obvious what type of dataframe the table is, so prob best for the examples to be explicit
Note: All the docstrings will be updated to reflect the new API, this just signalling what will need updating