Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splink 4 dialect agnostic blocking rules #1890

Merged
merged 25 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b857066
Remove old style blocking rule files
RobinL Jan 25, 2024
7b8968e
first cut at blocking rule creator
RobinL Jan 25, 2024
d4c8158
Remove deprecated exact_match_rule function and replace it with block…
RobinL Jan 25, 2024
f09b10e
Add blocking rule instantiation in Linker class
RobinL Jan 26, 2024
84f827f
Merge branch 'splink4_dev' into block_on
RobinL Jan 26, 2024
faf8616
Refactor column expression names in blocking rule creator
RobinL Jan 26, 2024
2ccfa74
estimate using em now takes BlockingRuleCreator
RobinL Jan 27, 2024
c0ef527
Progress on getting tests passing
RobinL Jan 27, 2024
721197c
Refactor blocking rule creation and add tests
RobinL Jan 27, 2024
ae62d43
use new block_on in settings validation tests
RobinL Jan 27, 2024
e4d2348
Add get_blocking_rule method to BlockingRuleCreator
RobinL Jan 27, 2024
abd897a
Further work to migrate tests to new block_on
RobinL Jan 27, 2024
530089c
Refactor test_blocking.py: Rename test_binary_composition_internals_O…
RobinL Jan 27, 2024
cc7e78d
Remove unused import in test_blocking.py
RobinL Jan 27, 2024
d7b5cf0
Add CustomRule
RobinL Jan 27, 2024
5d1b6c0
Refactor blocking rule import and update salting rule
RobinL Jan 27, 2024
e1f017d
Add SQL dialect to level_dict
RobinL Jan 27, 2024
9d871cf
Refactor blocking rule composition and add salting support
RobinL Jan 28, 2024
f9b5556
Fix blocking rule creation in tests
RobinL Jan 28, 2024
face458
Remove code to limit dataframe to 100 rows
RobinL Jan 28, 2024
82cb590
Remove unused blocking rule library and SQLite helper imports
RobinL Jan 28, 2024
88f4988
Add blocking rule library to Splink package
RobinL Jan 28, 2024
13963ef
Update blocking rule imports
RobinL Jan 28, 2024
bcc375e
Update import statement in test_analyse_blocking.py
RobinL Jan 28, 2024
927cccb
raise error if user passes list to block_on
RobinL Jan 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions splink/athena/athena_helpers/athena_blocking_rule_imports.py

This file was deleted.

9 changes: 0 additions & 9 deletions splink/athena/blocking_rule_library.py

This file was deleted.

2 changes: 1 addition & 1 deletion splink/blocking.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from .linker import Linker


def blocking_rule_to_obj(br):
def blocking_rule_to_obj(br) -> BlockingRule:
if isinstance(br, BlockingRule):
return br
elif isinstance(br, dict):
Expand Down
352 changes: 0 additions & 352 deletions splink/blocking_rule_composition.py

This file was deleted.

Loading
Loading