fix: checker handle source unavailable #1134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrMatsko
changed the title
AleksandrMatsko
changed the title
AleksandrMatsko
commented
Jan 15, 2025
| @@ -132,24 +132,17 @@ func (triggerChecker *TriggerChecker) handleFetchError(checkData moira.CheckData | |||
| triggerChecker.trigger.ClusterKey(), | |||
| ) | |||
| } | |||
| case remote.ErrRemoteTriggerResponse: | |||
| timeSinceLastSuccessfulCheck := checkData.Timestamp - checkData.LastSuccessfulCheckTimestamp | |||
| if timeSinceLastSuccessfulCheck >= triggerChecker.ttl { | |||
There was a problem hiding this comment.
Убрал это условие, т.к. оно было очень странным:
- если "повезло" и источник оказался недоступен в момент проверки триггера, то триггер перейдёт в EXCEPTION, если с момента проверки прошло более
ttlсекунд (это которые "Set NODATA if has no value for ttl seconds"). Плюс к этому здесь генерилось 2NotificationEvent, в случае выполнения условия. - иначе триггер состояние не поменяет + к этому, если источник остаётся не доступным, то триггер вообще не будет проверяться (т.к. если источник недоступен, то триггеры не шедулятся на проверку), т.е. не перейдёт в EXCEPTION
Если я что-то не учёл/не правильно понял, сигнализируйте)
There was a problem hiding this comment.
Может это какая-то попытка обработать ситуацию, когда ремоут был недоступен очень давно? Не знаю, тоже нет идей, почему так сделано
Tetrergeru
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In #1085 retries to Graphite remote metrics source were added. So new error
ErrRemoteUnavailablewas added.This PR refactors checker logic to proper handle
ErrRemoteUnavailableandErrRemoteTriggerResponse. Also add tests for handling fetch errors