Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dts-plugin): optimize dev behavior #3424

Merged
merged 21 commits into from
Jan 14, 2025
Merged

fix(dts-plugin): optimize dev behavior #3424

merged 21 commits into from
Jan 14, 2025

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Jan 6, 2025

Description

This pr fix serval dts issues , help optimize dev behavior :

  • feat: support pass headers when request types url
  • fix: set outputDir default value, pure rspack project not pass compiler.outputPath
  • fix: use remoteTarPath first to fetch hot types and remove emitDevFiles logic in GenerateTypesPlugin
  • fix: only consume types in dev
  • fix: throw error while downloading types archive hit historyApiFallback
  • fix: generateTypes should after consumeTypes finished
  • fix: dev plugin should apply after fetchPromise resolved
  • fix(enhanced): no push ModuleFederationPlugin self

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: 120fc23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@module-federation/dts-plugin Patch
@module-federation/enhanced Patch
@module-federation/manifest Patch
@module-federation/rspack Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/runtime Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/esbuild Patch
@module-federation/runtime-core Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 120fc23
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6784e26572baa500084192a1
😎 Deploy Preview https://deploy-preview-3424--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/dts-plugin/src/core/lib/utils.ts Dismissed Show dismissed Hide dismissed
@2heal1 2heal1 force-pushed the fix/dev-consume-types branch from da84187 to f773237 Compare January 8, 2025 12:48
@2heal1 2heal1 changed the title fix(dts-plugin): only consume types in dev WIP:fix(dts-plugin): only consume types in dev Jan 8, 2025
@2heal1 2heal1 changed the title WIP:fix(dts-plugin): only consume types in dev WIP: fix(dts-plugin): only consume types in dev Jan 8, 2025
@2heal1 2heal1 changed the title WIP: fix(dts-plugin): only consume types in dev fix(dts-plugin): optimize dev behavior Jan 13, 2025
@2heal1 2heal1 merged commit 6e3afc6 into main Jan 14, 2025
17 checks passed
@2heal1 2heal1 deleted the fix/dev-consume-types branch January 14, 2025 07:46
@2heal1 2heal1 mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants