Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3000-home): add trailing slash on antd and lodash shared config #2038

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

ryok90
Copy link
Contributor

@ryok90 ryok90 commented Jan 26, 2024

Description

Added a trailing slash to the shared config on the examples from 3000-home, 3001-shop, and 3002-checkout that were using the Next.js plugin.
The slash is needed for them to be properly shared since it will cause webpack to partially match the optimization of the imports that Next.js started doing since 13.5 to some packages.

Related Issue

This should solve #2037.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation. (No doc to update)

@ScriptedAlchemy ScriptedAlchemy merged commit 349c73a into module-federation:main Jan 28, 2024
7 checks passed
@2heal1 2heal1 mentioned this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants