Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(enhanced): adjust add federation init process #2035

Merged
merged 31 commits into from
Mar 27, 2024

Conversation

nyqykk
Copy link
Contributor

@nyqykk nyqykk commented Jan 26, 2024

Description

change federation init to entryPlugin to make sure init at the beginning

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@ScriptedAlchemy
Copy link
Member

Is this the same idea as my init pr?

If so, I can work on this - there's a failing test case here when runtimeChunk: single

in that case, I add a second ContainerEntry with {name + '_partial', runtime:false}

If runtime is false, you do not want to addEntry again.

@nyqykk
Copy link
Contributor Author

nyqykk commented Jan 29, 2024

Is this the same idea as my init pr?

If so, I can work on this - there's a failing test case here when runtimeChunk: single

in that case, I add a second ContainerEntry with {name + '_partial', runtime:false}

If runtime is false, you do not want to addEntry again.

yes this is similar to your init pr, this EntryPlugin is to add init federation runtime as a entry chunk in remoteEntry.

nyqykk and others added 4 commits March 18, 2024 17:35
… in runtime bootstrap (#2057)

Co-authored-by: ScriptedAlchemy <zackaryjackson@bytedance.com>
Co-authored-by: 2heal1 <TwoHeal@163.com>
Co-authored-by: nyqykk <1327719263@qq.com>
# Conflicts:
#	packages/nextjs-mf/README.md
@ScriptedAlchemy ScriptedAlchemy merged commit df3ef24 into main Mar 27, 2024
7 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the chore/prefetch-type branch March 27, 2024 04:54
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
ScriptedAlchemy added a commit that referenced this pull request Apr 3, 2024
@zhoushaw zhoushaw restored the chore/prefetch-type branch April 8, 2024 10:02
ScriptedAlchemy added a commit that referenced this pull request Apr 9, 2024
…2271)

Co-authored-by: ScriptedAlchemy <zackaryjackson@bytedance.com>
@2heal1 2heal1 mentioned this pull request Apr 10, 2024
@zhoushaw zhoushaw deleted the chore/prefetch-type branch December 19, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants