fix: window.location.origin will be 'null' in iframe srcDoc (#1956)

module-federation · Jan 15, 2024 · b129098 · b129098
1 parent 1147f48
commit b129098
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/weak-jars-tap.md b/.changeset/weak-jars-tap.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/runtime': patch
+---
+
+fix: window.location.origin will be "null" in iframe srcDoc
diff --git a/packages/runtime/src/core.ts b/packages/runtime/src/core.ts
@@ -764,7 +764,7 @@ export class FederationHost {
         }
         // Set the remote entry to a complete path
         if ('entry' in remote) {
-          if (isBrowserEnv()) {
+          if (isBrowserEnv() && !remote.entry.startsWith('http')) {
             remote.entry = new URL(remote.entry, window.location.origin).href;
           }
         }